-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master_parts_list_raw.csv #351
Conversation
JoshSharpe
commented
Dec 21, 2021
•
edited
Loading
edited
- Added file location for 3D printed encoder STL file.
- Updated T5 part to require 20, instead of 1. Section 3.9 of the PCB Assembly requires 20 for the Roboclaw standoffs but currently the parts list suggests only ordering 1.
- Added file location for 3D printed encoded STL file. - Updated 4.5x12" plate from servo city (discontinued) to Sculpto - Updated T5 part to require 20, instead of 1. Section 3.9 of the PCB Assembly requires 20 for the Roboclaw standoffs but currently the parts list suggests only ordering 1.
I'm closing this because the suggested file for laser cutting is a direct copy from ServoCity and they might not like that due to their patents.It also has extra holes which might compromise the strength and adds to the cost. I've replace the file and added some additional document in pull request #353. The change to the T5 part will need to be redone. |
Hmm, @dcschooley I didn't mention ServoCity's 4.5x12" part in the PR. I just removed ServoCity from the part all together and said it needs to be laser cut. The filename I refer to is the first bullet point. I believe we are not on the same page. |
I might have misinterpreted what you said on Slack. If so, I'm sorry about that. I thought you had converted the ServoCity drawing to something that could be laser cut. That's a good start, but probably isn't great because ServoCity has the design patented. That may or may not matter. In any case, the drawing in my lacks the extra holes, which saves strength and cost. It also has larger holes to pass the motor wires into the body, and that will be needed for the revised PCB rev. I've reopened the PR for you. Please remove the stuff about the 4.5x12 plate and all should be good. |
@JoshSharpe ping on the above, we'd love to have your contribution merged so others can benefit as well! Thanks |
Removed the change @dcschooley requested. Should be good to merge if approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.